x

libs/partners/groq/tests/unit_tests/test_standard.py

@@ -2,12 +2,13 @@
 
 from typing import Type
 
+import pytest
 from langchain_core.language_models import BaseChatModel
 from langchain_core.runnables import RunnableBinding
 from langchain_standard_tests.unit_tests.chat_models import (  # type: ignore[import-not-found]
     ChatModelUnitTests,
     Person,
     my_adder_tool,
 )
 
 from langchain_groq import ChatGroq
@@ -18,10 +19,6 @@
     def chat_model_class(self) -> Type[BaseChatModel]:
         return ChatGroq
 
+    @pytest.mark.xfail(reason="Groq does not support tool_choice='any'")
     def test_bind_tool_pydantic(self, model: BaseChatModel) -> None:
-        """Does not currently support tool_choice='any'."""
-        if not self.has_tool_calling:
-            return
-
-        tool_model = model.bind_tools([Person, Person.schema(), my_adder_tool])
-        assert isinstance(tool_model, RunnableBinding)
+        super().test_bind_tool_pydantic(model)

libs/standard-tests/langchain_standard_tests/base.py

@@ -40,9 +40,27 @@ def explore_bases(cls: Type) -> None:
         deleted_tests = base_tests - running_tests
         assert not deleted_tests, f"Standard tests deleted: {deleted_tests}"
 
-        overriden_tests = [
+        overridden_tests = [
             method
             for method in running_tests
             if getattr(self.__class__, method) is not getattr(comparison_class, method)
         ]
-        assert not overriden_tests, f"Standard tests overridden: {overriden_tests}"
+
+        def is_xfail(method: str) -> bool:
+            m = getattr(self.__class__, method)
+            if not hasattr(m, "pytestmark"):
+                return False
+            marks = m.pytestmark
+            return any(
+                mark.name == "xfail" and mark.kwargs.get("reason") for mark in marks
+            )
+
+        overridden_not_xfail = [
+            method for method in overridden_tests if not is_xfail(method)
+        ]
+        assert not overridden_not_xfail, (
+            "Standard tests overridden without "
+            f'@pytest.mark.xfail(reason="..."): {overridden_not_xfail}\n'
+            "Note: reason is required to explain why the standard test has an expected "
+            "failure."
+        )