Neo4j: Fixed similarity docs #23913
Merged
Neo4j: Fixed similarity docs #23913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
community
eyurtsev
reviewed
Jul 5, 2024
| @@ -1077,13 +1092,19 @@ def similarity_search_by_vector( | |||
| embedding: List[float], | |||
| k: int = 4, | |||
| filter: Optional[Dict[str, Any]] = None, | |||
| params: Dict[str, Any] = {}, | |||
There was a problem hiding this comment.
This introduces a bug since param is exposed in the function signature, but isn't propagated
There was a problem hiding this comment.
Thank you very much for your feedback. I forgot to use the params attribute.
Already updated the PR.
This change was basically to keep all the methods with similar signatures, since they all use similarity_search_with_score_by_vector method that receives the params argument.
eyurtsev
requested changes
Jul 5, 2024
There was a problem hiding this comment.
@RafaelXokito thanks for the PR! When you resolve the issue, feel free to ask me to re-review the code
|
@eyurtsev please review this PR. |
eyurtsev
approved these changes
Jul 11, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: There was missing some documentation regarding the
filterandparamsattributes in similarity search methods.