-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
langchain_huggingface: Fix multiple GPU usage bug in from_model_id function #23628
Open
kenchanLOL
wants to merge
15
commits into
langchain-ai:master
Choose a base branch
from
kenchanLOL:fix-hfpipeline-multigpu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−3
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7a2b7ee
Fix multiple GPU usage bug in from_model_id function
kenchanLOL 7e635b4
remove the error statement for backwards compatiblity
kenchanLOL f98f992
restores lines accidentally deleted
kenchanLOL f5ff450
fix lint E501 error on lin 102, 103
kenchanLOL d010fb3
Merge branch 'master' into fix-hfpipeline-multigpu
kenchanLOL fb774b5
Merge branch 'master' into fix-hfpipeline-multigpu
kenchanLOL cd90167
Merge branch 'master' into fix-hfpipeline-multigpu
kenchanLOL 0c49e7a
Merge branch 'master' into fix-hfpipeline-multigpu
hinthornw 802b2c9
remove trailing space
kenchanLOL 3754828
Merge branch 'fix-hfpipeline-multigpu' of https://github.com/kenchanL…
kenchanLOL 836ba88
fix huggingface_pipeline.py:108: error: Unsupported target for indexe…
kenchanLOL 1975792
Merge branch 'master' into fix-hfpipeline-multigpu
efriis acd3803
Update libs/partners/huggingface/langchain_huggingface/llms/huggingfa…
kenchanLOL 2d2309a
Apply suggestions from code review
kenchanLOL dd31867
Change default value of device argument to enable suggestions functio…
kenchanLOL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to keep this passthrough incase transformers uses it in future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar reason as above. There is also a similar parameter validation to check if both
device
anddevice_map
are not None inpipeline
. So, It would always be triggered as the current default value for device is -1 and device_map is also not None (either be 'auto' or a dictionary). So, we cant simply keep it without considering thedevice
parameter value.