🐛 fix: missing kwargs in from_agent_and_tools in dataframe agent #2285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchase17
reviewed
Apr 2, 2023
Contributor
hwchase17
left a comment
hwchase17
left a comment
There was a problem hiding this comment.
**kwargs also gets passed to ZeroShotAgent, need someway to differentiate them
could just add return_intermediate_steps to the function signature
Contributor
Author
|
@hwchase17 Thanks for the review! Updated now with |
hwchase17
approved these changes
Apr 2, 2023
Contributor
hwchase17
left a comment
hwchase17
left a comment
There was a problem hiding this comment.
this looks great to me! thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I've noticed a bug in
create_pandas_dataframe_agent. When calling it with argumentreturn_intermediate_steps=True, it doesn't return the intermediate step. I think the issue is thatkwargswas not passed where it needed to be passed. It should be passed intoAgentExecutor.from_agent_and_toolsPlease correct me if my solution isn't appropriate and I will fix with the appropriate approach.