community: Instantiate GPT4AllEmbeddings with parameters #21238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: embeddings
Alex-J-W
force-pushed
the
enh/allow-set-gpt4allembeddings-parameters
branch
4 times, most recently
from
edfc20c
to
382a9cc
Compare
hwchase17
reviewed
May 6, 2024
| @@ -19,14 +19,32 @@ class GPT4AllEmbeddings(BaseModel, Embeddings): | |||
|
|
|||
| client: Any #: :meta private: | |||
|
|
|||
| def __init__( | |||
There was a problem hiding this comment.
- I am not used to
pydantic. Updated the PR to adopt the pydanticBaseModelconvention and removed the__init__. - Edited the docstring based on what i have seen in
huggingface.py.
Alex-J-W
force-pushed
the
enh/allow-set-gpt4allembeddings-parameters
branch
from
382a9cc
to
92059b5
Compare
Alex-J-W
force-pushed
the
enh/allow-set-gpt4allembeddings-parameters
branch
from
b23e084
to
d98db97
Compare
hwchase17
approved these changes
May 8, 2024
dosubot
bot
added
the
lgtm
kyle-cassidy
pushed a commit
to kyle-cassidy/langchain
that referenced
this pull request
May 10, 2024
…i#21238) ### GPT4AllEmbeddings parameters --- **Description:** As of right now the **Embed4All** class inside _GPT4AllEmbeddings_ is instantiated as it's default which leaves no room to customize the chosen model and it's behavior. Thus: - GPT4AllEmbeddings can now be instantiated with custom parameters like a different model that shall be used. --------- Co-authored-by: AlexJauchWalser <alexander.jauch-walser@knime.com>
ccurme
pushed a commit
that referenced
this pull request
Aug 7, 2024
…gpt4all_kwargs (#25124) - **Description:** Instantiating `GPT4AllEmbeddings` with no `gpt4all_kwargs` argument raised a `ValidationError`. Root cause: #21238 added the capability to pass `gpt4all_kwargs` through to the `GPT4All` instance via `Embed4All`, but broke code that did not specify a `gpt4all_kwargs` argument. - **Issue:** #25119 - **Dependencies:** None - **Twitter handle:** [`@metadaddy`](https://twitter.com/metadaddy)
olgamurraft
pushed a commit
to olgamurraft/langchain
that referenced
this pull request
Aug 16, 2024
…gpt4all_kwargs (langchain-ai#25124) - **Description:** Instantiating `GPT4AllEmbeddings` with no `gpt4all_kwargs` argument raised a `ValidationError`. Root cause: langchain-ai#21238 added the capability to pass `gpt4all_kwargs` through to the `GPT4All` instance via `Embed4All`, but broke code that did not specify a `gpt4all_kwargs` argument. - **Issue:** langchain-ai#25119 - **Dependencies:** None - **Twitter handle:** [`@metadaddy`](https://twitter.com/metadaddy)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPT4AllEmbeddings parameters
Description:
As of right now the Embed4All class inside GPT4AllEmbeddings is instantiated as it's default which leaves no room to customize the chosen model and it's behavior. Thus: