Skip to content

Fix wrong prompt in refine chain #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2023
Merged

Fix wrong prompt in refine chain #1770

merged 1 commit into from
Mar 19, 2023

Conversation

@nqbao
Copy link
Contributor

@nqbao nqbao commented Mar 19, 2023

I got this during testing

ValueError: Missing some input keys: {'existing_answer'}

Upon review, the initial prompt should be QUESTION_PROMPT_SELECTOR.

@nqbao
Copy link
Contributor Author

nqbao commented Mar 19, 2023

@hwchase17 can you take a look? thanks!

hwchase17
hwchase17 approved these changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, thanks!

@hwchase17 hwchase17 merged commit 85e4dd7 into langchain-ai:master Mar 19, 2023
@LukasMosser LukasMosser mentioned this pull request Mar 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hwchase17 hwchase17 hwchase17 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nqbao @hwchase17 @bnguyenrk