Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Use _AstraDBCollectionEnvironment in AstraDB VectorStore (community) #17635

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Feb 16, 2024

Another PR will be done for the langchain-astradb package.

Note: for future PRs, devs will be done in the partner package only. This one is just to align with the rest of the components in the community package and it fixes a bunch of issues.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 16, 2024
Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Feb 16, 2024 1:24pm

@dosubot dosubot bot added Ɑ: vector store Related to vector store module 🔌: astradb Primarily related to AstraDB integrations 🤖:refactor A large refactor of a feature(s) or restructuring of many files labels Feb 16, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 16, 2024
@eyurtsev eyurtsev merged commit 19ebc74 into langchain-ai:master Feb 16, 2024
58 checks passed
@eyurtsev
Copy link
Collaborator

@cbornet once the partner package is ready, you could use the @deprecated decorator to ask users to move to the partner package

@cbornet cbornet deleted the astra-vector-store-refacto branch February 16, 2024 16:55
@cbornet
Copy link
Collaborator Author

cbornet commented Feb 16, 2024

Yes. I think the AstraDB VectorStore is already annotated as deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔌: astradb Primarily related to AstraDB integrations lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:refactor A large refactor of a feature(s) or restructuring of many files size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants