Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: add fixes for AzureSearch after update to stable azure-search-documents library #17599

Merged
merged 2 commits into from
Feb 16, 2024
Merged

community: add fixes for AzureSearch after update to stable azure-search-documents library #17599

merged 2 commits into from
Feb 16, 2024

Conversation

kristapratico
Copy link
Contributor

  • Description: Addresses the bugs described in linked issue where an import was erroneously removed and the rename of a keyword argument was missed when migrating from beta --> stable of the azure-search-documents package
  • Issue: regressions with AzureSearch vectorstore update to v11.4.0 #17598
  • Dependencies: N/A
  • Twitter handle: N/A

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 15, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 10:35pm

@dosubot dosubot bot added Ɑ: vector store Related to vector store module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Feb 15, 2024
@mattgotteiner
Copy link
Contributor

Thanks - this looks great, appreciated

@kristapratico kristapratico mentioned this pull request Feb 15, 2024
Merged
@mattgotteiner
Copy link
Contributor

@baskaryan

@kristapratico
Copy link
Contributor Author

Failing test in CI seems unrelated - it's also failing on other open PRs.

@matthewgotteiner
Copy link

I’m going to add a test after this is merged

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 16, 2024
@baskaryan baskaryan merged commit bf8e3c6 into langchain-ai:master Feb 16, 2024
56 of 58 checks passed
@kristapratico kristapratico deleted the azure-search-fix branch February 16, 2024 17:11
@kristapratico kristapratico mentioned this pull request Feb 16, 2024
Closed
@mattgotteiner mattgotteiner mentioned this pull request Feb 17, 2024
Merged
@dosubot dosubot bot mentioned this pull request Feb 19, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baskaryan baskaryan baskaryan approved these changes

@mattgotteiner mattgotteiner mattgotteiner approved these changes

Assignees
No one assigned
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kristapratico @mattgotteiner @matthewgotteiner @baskaryan