community: Use astrapy built-in pagination prefetch in AstraDBLoader #17569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: doc loader
cbornet
changed the title
eyurtsev
approved these changes
Feb 15, 2024
| @@ -33,6 +30,7 @@ class AstraDBLoader(BaseLoader): | |||
| def __init__( | |||
| self, | |||
| collection_name: str, | |||
| *, | |||
There was a problem hiding this comment.
Not related to this PR, but the loader could use a lot of in code documentation. It's surfaced in the APIReference and in interactive environments. Some of the variables are self explanatory, but other variables like filter_criteria or projection would require reading through the code or fishing for documentation somewhere else.
There was a problem hiding this comment.
Sure. I'll add pydoc as follow-up PR.
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.