core[minor]: add name to basemessage #17539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:L
added 2 commits
February 14, 2024 10:50
efriis
commented
Feb 14, 2024
Comment on lines
32
to
60
| assert AIMessageChunk(content="I am") + HumanMessageChunk( | ||
| content=" indeed." | ||
| ) == AIMessageChunk( | ||
| content="I am indeed." | ||
| ), "MessageChunk + MessageChunk should be a MessageChunk of same class as the left side" # noqa: E501 | ||
|
|
||
| assert ( | ||
| AIMessageChunk(content="", additional_kwargs={"foo": "bar"}) | ||
| + AIMessageChunk(content="", additional_kwargs={"baz": "foo"}) | ||
| == AIMessageChunk(content="", additional_kwargs={"foo": "bar", "baz": "foo"}) | ||
| assert AIMessageChunk( | ||
| content="", additional_kwargs={"foo": "bar"} | ||
| ) + AIMessageChunk(content="", additional_kwargs={"baz": "foo"}) == AIMessageChunk( | ||
| content="", additional_kwargs={"foo": "bar", "baz": "foo"} | ||
| ), "MessageChunk + MessageChunk should be a MessageChunk with merged additional_kwargs" # noqa: E501 | ||
|
|
||
| assert ( | ||
| AIMessageChunk( | ||
| content="", additional_kwargs={"function_call": {"name": "web_search"}} | ||
| ) | ||
| + AIMessageChunk( | ||
| content="", additional_kwargs={"function_call": {"arguments": None}} | ||
| ) | ||
| + AIMessageChunk( | ||
| content="", additional_kwargs={"function_call": {"arguments": "{\n"}} | ||
| ) | ||
| + AIMessageChunk( | ||
| content="", | ||
| additional_kwargs={ | ||
| "function_call": {"arguments": ' "query": "turtles"\n}'} | ||
| }, | ||
| ) | ||
| == AIMessageChunk( | ||
| content="", | ||
| additional_kwargs={ | ||
| "function_call": { | ||
| "name": "web_search", | ||
| "arguments": '{\n "query": "turtles"\n}', | ||
| } | ||
| }, | ||
| ) | ||
| assert AIMessageChunk( | ||
| content="", additional_kwargs={"function_call": {"name": "web_search"}} | ||
| ) + AIMessageChunk( | ||
| content="", additional_kwargs={"function_call": {"arguments": None}} | ||
| ) + AIMessageChunk( | ||
| content="", additional_kwargs={"function_call": {"arguments": "{\n"}} | ||
| ) + AIMessageChunk( | ||
| content="", | ||
| additional_kwargs={"function_call": {"arguments": ' "query": "turtles"\n}'}}, | ||
| ) == AIMessageChunk( | ||
| content="", | ||
| additional_kwargs={ | ||
| "function_call": { | ||
| "name": "web_search", | ||
| "arguments": '{\n "query": "turtles"\n}', | ||
| } | ||
| }, |
There was a problem hiding this comment.
no changes here - just formatting
| @@ -192,6 +185,21 @@ def test_multiple_msg() -> None: | |||
| assert messages_from_dict(messages_to_dict(msgs)) == msgs | |||
|
|
|||
|
|
|||
| def test_multiple_msg_with_name() -> None: | |||
There was a problem hiding this comment.
add test to confirm name loads/dumps with dict
| @@ -480,3 +488,49 @@ def test_convert_to_messages() -> None: | |||
| HumanMessage(content="Hello!"), | |||
| AIMessage(content="Hi!"), | |||
| ] | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize( | |||
There was a problem hiding this comment.
test all message types with name except tool (different case)
efriis
commented
Feb 14, 2024
There was a problem hiding this comment.
add "name" to snapshots
efriis
changed the title
nfcampos
approved these changes
Feb 14, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional name param to our base message to support passing names into LLMs.
OpenAI supports having a name on anything except tool message now (system, ai, user/human).