Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RAG input types #12684

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Add RAG input types #12684

merged 3 commits into from
Nov 1, 2023

Conversation

rlancemartin
Copy link
Collaborator

No description provided.

@vercel Vercel
Copy link

vercel bot commented Oct 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2023 0:10am

@dosubot dosubot bot added Ɑ: models Related to LLMs or chat model modules 🤖:improvement Medium size change to existing code to handle new use-cases 🔌: pinecone Primarily related to Pinecone vector store integration labels Oct 31, 2023
efriis
efriis reviewed Oct 31, 2023
View reviewed changes
templates/rag-elasticsearch/rag_elasticsearch/chain.py Outdated

# Add typing for input
class Question(BaseModel):
__root__: str
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be incorrect. Maybe something more similar to https://github.com/langchain-ai/langchain/pull/12682/files#diff-d26831cc3cbf5bf1acc93d4768150a54333b0c34d881d33e12f091dd50b18298R45-R49

@efriis efriis added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Nov 1, 2023
@efriis efriis merged commit f0eba1a into master Nov 1, 2023
@efriis efriis deleted the rlm/template_input_types branch November 1, 2023 00:13
xieqihui pushed a commit to xieqihui/langchain that referenced this pull request Nov 21, 2023
@rlancemartin @efriis @xieqihui
Add RAG input types (langchain-ai#12684)
b48c789 
Co-authored-by: Erick Friis <erick@langchain.dev>
hoanq1811 pushed a commit to hoanq1811/langchain that referenced this pull request Feb 2, 2024
@rlancemartin @efriis
Add RAG input types (langchain-ai#12684)
fe5f19e 
Co-authored-by: Erick Friis <erick@langchain.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

Assignees
No one assigned
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: models Related to LLMs or chat model modules 🔌: pinecone Primarily related to Pinecone vector store integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rlancemartin @efriis