Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parameterized queries to select SQL schemas. #11356

Merged
merged 7 commits into from
Oct 4, 2023

Conversation

obi1kenobi
Copy link
Collaborator

@obi1kenobi obi1kenobi commented Oct 3, 2023

This switches to parameterized queries for selecting schemas for all databases, except DuckDB for which I wasn't able to figure out how to get parameterized queries to work: Mause/duckdb_engine#796

For all the other databases, I followed the parameterized query approach described by their docs.

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 4:30am

@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Oct 3, 2023
@obi1kenobi
Copy link
Collaborator Author

I haven't been able to figure out how to do this properly for the duckdb driver, opened an issue: Mause/duckdb_engine#796

@obi1kenobi obi1kenobi force-pushed the pg/use-parameterized-queries branch from 6667ac4 to c0f7c10 Compare October 3, 2023 23:57
@nfcampos nfcampos merged commit 289de60 into master Oct 4, 2023
@nfcampos nfcampos deleted the pg/use-parameterized-queries branch October 4, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants