Use config.embedding_dimensions
(if specified) in the RedisVectorStore instead of embedding dummy text. #35
Closed
Description
Thank you for your excellent library.
Making API calls or performing time-consuming tasks during module import or class initialization is a bad idea. You've already considered this by providing the embedding_dimensions
argument and using a dummy embedding as a fallback method:
langchain-redis/libs/redis/langchain_redis/vectorstores.py
Lines 273 to 278 in 2bdf379
However, a few lines later, you didn't use the provided variable and embedded dummy text again:
langchain-redis/libs/redis/langchain_redis/vectorstores.py
Lines 326 to 335 in 2bdf379
Metadata
Assignees
Labels
No labels