fix: Fix hybrid search bugs #257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the 2nd Major issue in #234, related to Configuration and Querying Issues
Issue breakdown:
Inconsistent k Parameter: For hybrid searches, the dense search LIMIT was tied to the final k parameter, while the sparse search used its own secondary_top_k.
Late Initialization of HybridSearchConfig: The HybridSearchConfig was initialized after the k parameter was calculated, which could lead to incorrect behavior if the config was passed dynamically via
kwargs.Overview of the changes:
The __query_collection method now uses a separate
dense_limitfor the dense search query.If HybridSearchConfig is active, dense_limit is set to primary_top_k. For dense-only searches, dense_limit defaults to the final k value, preserving the existing behavior.
The hybrid_search_config is now initialized at the beginning of
__query_collection, ensuring that anykwargsoverrides are handled beforekordense_limitare calculated.