feat: add async and sync hybrid search index creation methods #244
+206
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JHSeo-git Thank you opening this PR. Could you please add units tests similar to the ones that exist for the AsyncPGVectorStore shown here. |
JHSeo-git
force-pushed
the
add-apply-hybrid-search-index-in-vectorstore
branch
from
c194523 to
49a79cc
Compare
- update postgres_db name for test in DEVELOPMENT.md - update postgres_port for test in utils.py - add psycopg[binary] for test using binary psycopg
|
@dishaprakash Thanks for the feedback 😄! I’ve added unit tests similar to the existing AsyncPGVectorStore ones, along with a few related configuration updates. Let me know if there’s anything else you’d like to see covered. |
- add tests for creating and validating hybrid search indexes using HybridSearchConfig - add tests for applying hybrid search indexes to tables with and without TSV columns - add tests for applying hybrid search indexes in both async and sync versions - add hybrid table cleanup logic to existing tests
JHSeo-git
force-pushed
the
add-apply-hybrid-search-index-in-vectorstore
branch
from
eab90c1 to
702d6dd
Compare
averikitsch
reviewed
Aug 18, 2025
tests/utils.py
Outdated
| POSTGRES_DB = os.environ.get("POSTGRES_DB", "langchain_test") | ||
|
|
||
| POSTGRES_PORT = os.environ.get("POSTGRES_PORT", "5432") | ||
| POSTGRES_PORT = os.environ.get("POSTGRES_PORT", "6024") |
There was a problem hiding this comment.
Please revert this change
dishaprakash
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #238 for details.
Added code to expose the functions (aapply_hybrid_search_index, apply_hybrid_search_index) for adding an index to the tsv column in hybrid search.
I also fixed minor typos in the existing test code for better readability.
langchain_postgres/v2/vectorstores.py: Added new index creation methodstests/unit_tests/v2/test_pg_vectorstore_index.py: Added comprehensive test coveragepyproject.toml: Updated test dependenciestests/utils.py: Minor updatesDEVELOPMENT.md: Minor updatesIt also includes changes to align test-related environment variable settings between
DEVELOPMENT.mdandutils.py.For testing, I initially attempted to use the existing dependency
psycopg, but on my current environment (not installed deps like libpq, MacBook Apple M4 Max), running with the existing dependency caused errors. To ensure compatibility across environments, I addedpsycopg[binary].psycopg error