Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sharing #38

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Add sharing #38

merged 1 commit into from
Mar 18, 2024

Conversation

eyurtsev
Copy link
Collaborator

Add sharing of extractors

@eyurtsev
Copy link
Collaborator Author

#35

@eyurtsev eyurtsev requested review from ccurme and bracesproul March 18, 2024 19:26
@eyurtsev eyurtsev merged commit 1a12200 into main Mar 18, 2024
6 checks passed
@eyurtsev eyurtsev deleted the eugene/add_sharing branch March 18, 2024 19:27
keys = sorted(response.json())
assert keys == ["description", "instruction", "name", "schema"]

assert response.json() == {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eyurtsev is sharing of few-shot examples supported?

Is it reasonable to do this by transmitting the extractor uuid among users?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows using the extractor by the extractor share id (including examples associated with it) but right now examples aren't visible and the shared extractor cannot be mutated using the share id.

Touch base tomorrow to discuss if there are any other patterns we need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants