Add Criteria Evals #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinthornw
commented
Aug 16, 2023
| return uuid4().hex[:8] | ||
|
|
||
|
|
||
| class EvaluatorRunnable(runnable.Runnable): |
There was a problem hiding this comment.
This would be avoidable if runnable lambdas would optionally pass the callback manager down to the function
hinthornw
force-pushed
the
wfh/criteria_evals
branch
from
0cbe43c to
54c3aa4
Compare
hinthornw
commented
Aug 16, 2023
| project_name=project_name, | ||
| tags=["int-test"] + tags, | ||
| ) | ||
| feedback = client.list_feedback( |
There was a problem hiding this comment.
I should return this by default in the evaluator function
hinthornw
force-pushed
the
wfh/criteria_evals
branch
from
54c3aa4 to
75adaba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.