fix(langgraph-checkpoint-aws): Allow limit configuration for AgentCoreMemorySaver get_tuple
#728
+53
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ltoniazzi, thanks for the suggestions in #719 - feel free to try out these changes and let me know if you have any additional feedback. |
ltoniazzi
reviewed
Oct 25, 2025
| async def aget_tuple(self, config: RunnableConfig) -> CheckpointTuple | None: | ||
| return self.get_tuple(config) | ||
| async def aget_tuple( | ||
| self, config: RunnableConfig, *, limit: int | None = None |
There was a problem hiding this comment.
I think limit is like a connection parameter, so it could be good to set it as an attribute when instantiating the saver, like for the postgres saver.
Also the user will not use aget_tuple, but usually only instantiate the saver. Other methods, like aget, aput, are usually only called by the langgraph internals.
ltoniazzi
reviewed
Oct 25, 2025
| checkpoint_config.session_id, checkpoint_config.actor_id | ||
| checkpoint_config.session_id, | ||
| checkpoint_config.actor_id, | ||
| 100 if limit is None else limit, |
There was a problem hiding this comment.
I think None could be allowed as a parameter?
If limit is an attribute it could just be self.limit here and set a default in the __init__?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #719.
This PR updates the AgentCore checkpointer to:
limitargument toAgentCoreMemorySaver.get_tuple(). Currently, this method will always use the default limit of 100 events inAgentCoreEventClient,get_events().AgentCoreEventClient,get_events(), exit from the response processing loop early if the number of events found exceedslimit. If this occurs, a warning will be returned to the user.