Skip to content

chore(aws): Add deprecation warning for ChatBedrock beta_use_converse_api #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v0.2.x
Choose a base branch
from
Open

chore(aws): Add deprecation warning for ChatBedrock beta_use_converse_api #722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion libs/aws/langchain_aws/chat_models/bedrock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
cast,
)

from langchain_core._api import LangChainDeprecationWarning
from langchain_core.callbacks import CallbackManagerForLLMRun
from langchain_core.language_models import (
BaseChatModel,
Expand Down Expand Up @@ -721,8 +722,11 @@ class ChatBedrock(BaseChatModel, BedrockBase):
"""A chat model that uses the Bedrock API."""

system_prompt_with_tools: str = ""

beta_use_converse_api: bool = False
"""Use the new Bedrock ``converse`` API which provides a standardized interface to
"""Note: this parameter is deprecated. Please use ChatBedrockConverse directly.

Use the new Bedrock ``converse`` API which provides a standardized interface to
all Bedrock models. Support still in beta. See ChatBedrockConverse docs for more."""

stop_sequences: Optional[List[str]] = Field(default=None, alias="stop")
Expand All @@ -749,6 +753,17 @@ def get_lc_namespace(cls) -> List[str]:
@model_validator(mode="before")
@classmethod
def set_beta_use_converse_api(cls, values: Dict) -> Any:
if "beta_use_converse_api" in values:
warnings.warn(
(
"`beta_use_converse_api` is deprecated and will be removed in "
"langchain-aws 1.0. Please use the purpose-built "
"ChatBedrockConverse class instead."
),
LangChainDeprecationWarning,
stacklevel=2,
)

model_id = values.get("model_id", values.get("model"))
base_model_id = values.get("base_model_id", values.get("base_model", ""))

Expand Down