edit styling to enable localization #1276
Conversation
|
Mintlify preview ID generated: preview-locali-1762278006-ca34b6d |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the documentation site's theme and styling configuration while restructuring the navigation to support multi-language documentation (English localization). The changes prepare the site for internationalization and apply new visual design tokens.
Key changes:
- Theme and styling updates: Changed from "aspen" to "palm" theme, updated dark mode color, changed heading font from "Inter" to "Manrope"
- CSS simplification: Removed custom color variables and dark mode styles, retained only utility overrides
- Navigation restructure: Wrapped the entire navigation in a
languagesarray with "en" language support, enabling future localization - Navigation terminology: Changed from "products" to "languages.products" structure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/style.css | Removed custom CSS variables and dark mode styles; simplified to essential utility overrides |
| src/docs.json | Changed theme to "palm", updated colors/fonts, restructured navigation with language wrapper for i18n support |
| a[href] code { | ||
| color: inherit !important; | ||
| text-decoration: none !important; /* Remove underline from code itself */ | ||
| padding: 0 !important; /* Remove padding to prevent gaps in parent link underline */ |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| .callout a, | ||
| [class*="callout"] a { | ||
| font-size: inherit !important; /* Match callout text size */ | ||
| color: inherit !important; /* Match callout text color */ |
There was a problem hiding this comment.
Line 18 (previously line 19) removed the 'text-decoration: inherit !important' rule for callout links. This change may affect the visual consistency of links within callouts. If the removal was intentional to simplify styling, ensure that callout links still have appropriate visual indicators (such as underlines) to distinguish them from regular callout text for accessibility.
| color: inherit !important; /* Match callout text color */ | |
| color: inherit !important; /* Match callout text color */ | |
| text-decoration: inherit !important; /* Ensure links are visually distinct */ |
|
Mintlify preview ID generated: preview-locali-1762287107-c6f95d2 |
|
Mintlify preview ID generated: preview-locali-1762287630-568be2b |
| "name": "Docs by LangChain", | ||
| "description": "Documentation for LangChain, LangGraph, LangSmith, and more.", | ||
| "colors": { | ||
| "primary": "#2F6868", | ||
| "light": "#84C4C0", | ||
| "dark": "#2F6868" | ||
| "dark": "#1C3C3C" |
There was a problem hiding this comment.
The dark color value has changed from '#2F6868' to '#1C3C3C', making it significantly darker. Consider documenting this color change in a changelog or migration guide if this is a breaking visual change that affects existing customizations or branding.
| @@ -18,7 +18,7 @@ | |||
| }, | |||
| "fonts": { | |||
| "heading": { | |||
| "family": "Inter" | |||
| "family": "Manrope" | |||
There was a problem hiding this comment.
The heading font has changed from 'Inter' to 'Manrope'. Verify that the Manrope font is properly loaded/available in the Mintlify theme, as missing fonts can cause fallback to system defaults and affect visual consistency.
Co-authored-by: Kathryn May <44557882+katmayb@users.noreply.github.com>
Co-authored-by: Kathryn May <44557882+katmayb@users.noreply.github.com>
|
Mintlify preview ID generated: preview-locali-1762287856-7e0a70b |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
README.md:1
- The horizontal rule uses four dashes
----instead of the standard three dashes---used elsewhere in the file (e.g., lines 40, 65, 318). For consistency, this should be changed to---.
# LangChain Docs
| "navigation": { | ||
| "products": [ | ||
| "languages": [ |
There was a problem hiding this comment.
According to the Mintlify docs.json schema, the navigation object should contain products directly, not wrapped in a languages array. The languages configuration should be at the root level of docs.json alongside navigation. This structure appears to be implementing custom internationalization support, but if this isn't officially supported by Mintlify or hasn't been verified to work, it could cause navigation issues. Please verify this structure is correct and document it if it's a custom implementation.
Overview
Type of change
Type: New styling and updated README