feat: add permissions system for filesystem access control#449
Draft
open-swe[bot] wants to merge 1 commit into
Draft
feat: add permissions system for filesystem access control#449open-swe[bot] wants to merge 1 commit into
open-swe[bot] wants to merge 1 commit into
Conversation
Ports Python PRs #2633, #2659, #2665 to JS. Adds FilesystemPermission rules with first-match-wins evaluation, pre-check denial, post-filter for ls/glob/grep, CompositeBackend route-scoped permission support, and path validation (leading slash, no .., no ~). Co-authored-by: Nick Hollon <274035459+nick-hollon-lc@users.noreply.github.com>
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports three Python PRs (#2633, #2659, #2665) to JS: adds a
FilesystemPermissionsystem withcreatePermissionMiddlewarethat enforces path-level read/write rules viawrapToolCall. Includes pre-check (blocks denied tool calls) and post-filter (strips denied paths from ls/glob/grep results). Supports CompositeBackend route-scoped permissions with sandbox defaults, and validates permission paths at construction time (rejects relative paths,..traversal,~).Test Plan
permissions.test.ts)Opened collaboratively by Nick Hollon and open-swe.