fix(localagent): stop re-seeding stream accumulator with previous rou…#2329
Open
MIKAZE3 wants to merge 1 commit into
Open
fix(localagent): stop re-seeding stream accumulator with previous rou…#2329MIKAZE3 wants to merge 1 commit into
MIKAZE3 wants to merge 1 commit into
Conversation
dadachann
requested changes
Jul 16, 2026
dadachann
left a comment
Contributor
There was a problem hiding this comment.
这个拆分粒度没问题,但分支已与 master 冲突,且 localagent.py 最近有后续改动。请 rebase 后补一个多轮 tool call 内容不重复的回归测试,再继续 review。
MIKAZE3
force-pushed
the
fix/localagent-duplicate-message
branch
from
July 16, 2026 09:18
d6728a8 to
17f59b4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…nd content When the LLM (e.g. MiniMax-M3) returns multiple rounds after tool calls, the _StreamAccumulator was initialized with initial_content=first_content, causing every subsequent round to repeat the entire first message. Remove the re-seeding so each round starts with a clean accumulator. Add regression test verifying multi-round tool call content is not duplicated.
MIKAZE3
force-pushed
the
fix/localagent-duplicate-message
branch
from
July 17, 2026 04:54
17f59b4 to
46f6b57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nd content
When the LLM (e.g. MiniMax-M3) returns multiple rounds after tool calls, the _StreamAccumulator was initialized with initial_content=first_content, causing every subsequent round to repeat the entire first message. Remove the re-seeding so each round starts with a clean accumulator.
概述 / Overview
更改前后对比截图 / Screenshots
检查清单 / Checklist
PR 作者完成 / For PR author
请在方括号间写
x以打勾 / Please tick the box withx项目维护者完成 / For project maintainer