Skip to content

Better Healthcheck Testing/Blank dbname/user Testing #44

Open
@reynoldsalec

Description

@reynoldsalec

We just implemented a fix to handle situations where the user specifies blank dbname/password/username for the db config. Ex:

services:
  database:
    type: mariadb
      creds:
        user: customusername
        password:
        database: customdbname

The fix: 017dba9

I put in a "test case" in the custom example to make sure a blank password wouldn't fail the healthcheck or otherwise create problems, however, I'm not testing blank user or database values. From some quick manual testing it looked like those worked ok, but would be good to explicitly test this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions