Skip to content

Error message says osslsigncode but code checks for signtool #11

Description

@rasa

The error message refers to osslsigncode, but checks for signtool.

code-sign-action/action.yml

Lines 251 to 252 in a5703d3

if [ "${{ steps.code-sign-action-internal.outputs.signtool }}" != "codesign" ]; then
echo "::error::You must specify osslsigncode, keylocker or smctl as your signtool! You specified ${{ steps.code-sign-action-internal.outputs.signtool }}."

code-sign-action/action.yml

Lines 266 to 269 in a5703d3

if [ "${{ steps.code-sign-action-internal.outputs.signtool }}" != "signtool" ] \
&& [ "${{ steps.code-sign-action-internal.outputs.signtool }}" != "keylocker" ] \
&& [ "${{ steps.code-sign-action-internal.outputs.signtool }}" != "smctl" ]; then
echo "::error::You must specify osslsigncode, keylocker or smctl as your signtool! You specified ${{ steps.code-sign-action-internal.outputs.signtool }}."

Also,

Note that signing is **not supported** on `linux` because you cannot sign binary files on Linux and it is not required for binaries to be signed anyway.

says you can't sign on Linux, but I use osslsigncode to sign on Linux. Perhaps this action could be expanded to use osslsigncode to sign on Linux?

If you are open to that idea, I can look into submitting a PR for your review.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions