First set of API improvements #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be better to set the handled accesses with Ruleset::new(accesses) to avoid a runtime error, but it doesn't fit with the Compatible::set_best_effort() usage. Signed-off-by: Mickaël Salaün <mic@digikod.net>
Require user to explicitely set the allowed accesses instead of using default ones. Because PathBeneath::allow_access() doesn't return error (but RulesetCreated::add_rule() does), it is not useful to have a dedicated setter nor a dedicated error like MissingHandledAccess. Signed-off-by: Mickaël Salaün <mic@digikod.net>
Simplifies tests with explicit ruleset creation from static ABI versions. Never use Ruleset::new() for tests to avoid inconsistent behaviors, except in lib.rs because of real-life tests. Signed-off-by: Mickaël Salaün <mic@digikod.net>
Making consecutive calls to Ruleset::handle_access() accumulate accesses instead of replacing should avoid pitfalls, and may be convenient to gradually build a ruleset with different levels of compatibility (see Ruleset::set_compatibility). Signed-off-by: Mickaël Salaün <mic@digikod.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits help write tests and don't impact the compatibility features (see #12).