Refactor lancedb_record_batch_reader_from_arrow to improve error handling #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
lancedb_record_batch_reader_from_arrowto return aLanceDBErrorcode and an optional error message, aligning it with other fallible APIs in the library. Previously, this function returnedNULLon failure, providing no context on why the Arrow import failed (e.g., schema validation errors vs. array import errors). This closes #7.Changes
lancedb_record_batch_reader_from_arrownow returnsLanceDBErrorinstead of a pointer.LanceDBRecordBatchReader** reader_out.char** error_message.SchemaandRecordBatchimport from the Arrow C ABI usinghandle_error.releasefunction if the import fails.Breaking Changes
The signature of
lancedb_record_batch_reader_from_arrowin include/lancedb.h has changed.Checklist