Locks up w/ Multiple Traces

[MrHamel]

When I launch ttl with ttl --interval 0.1 --pmtud --resolve-all --wide mineralcup.org, when I press "l" to list the multiple traces there are times where the app locks up solid (stops sending/receiving pings), and when I select another trace in the list that can sometimes also lock it up too, although with the latter it locks up before that trace is loaded.

This is while ttl is running in a Proxmox LXC container, Ubuntu 22.04.5 LTS.

-> # ttl --version
ttl 0.13.2

[lance0]

I just noticed this as well. I will try and get it patched as soon as possible.

[lance0]

Fixed in v0.13.3. The target list overlay was holding the session lock during the entire render, blocking the receiver thread from updating probe responses. Now extracts data quickly into owned structs before rendering.

Upgrade via brew upgrade ttl or cargo install ttl.

[MrHamel]

Fix is confirmed, thank you!

[MrHamel]

This issue has come back in v0.14 when running ttl --interval 0.1 --pmtud --rate 0 --resolve-all --wide mindat.org, where if I rapidly move between the list entries it can lock up on pressing enter again, or after the text-based dialog disappears when pressing enter.

Besides this, a minor UI improvement would be on 0-9 number press, it takes me to that trace and that dialog disappears, so I don't have to press a number, then enter.

[lance0]

Will give it a look thanks sir.

[lance0]

Fixed (again) in v0.14.1! 🎉

The regression was a different lock contention pattern - the Enter handler was closing the dialog before extracting the pause state, causing blocking when rapidly switching targets.

Fixes in this release:

• Extract data from locks in scoped blocks BEFORE updating UI state
• Number keys 1-9 now select AND close the dialog (your UI suggestion!)
• Same pattern applied to Tab/BackTab target switching
• Export clones session data before file I/O to avoid blocking during write

Upgrade via brew upgrade ttl or cargo install ttl.

[lance0]

@MrHamel the second lock contention fix shipped in v0.14.1 with the scoped lock extraction pattern. Has the rapid target switching issue come back, or is this resolved for you now?