fix!: bump IVF_RQ version for compatibility check#6097
Conversation
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
ReviewP1:
|
|
Hi @BubbleCal, I think the review raised by claude is valid:
Do we need to take care about this? |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
it's common that we just append a delta index and I think today all old_indices will always be with the same version, even on a new version of lance, we always respect the existing index's version when incremental indexing |
When appending to an existing index, the new delta's index_version was set to max(old_versions), but indices created by old Lance wrote index_version=0 (unset). This caused the delta to inherit version 0, making old Lance fall back to brute-force KNN instead of using the index. Fix by taking max(old_versions, current_library_version_for_type), so the appended index always declares at least the minimum required version for its index type. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
c691663 to
280e9a5
Compare
wjones127
left a comment
There was a problem hiding this comment.
Okay this should go good to go. Will merge once CI is green and we can make a release.
Summary - add IVF_RQ compatibility tests that run against the latest stable pylance release to ensure read/query compatibility both directions - update IndexDetails to report the actual highest vector version rather than a single constant --------- Co-authored-by: Will Jones <willjones127@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary