Skip to content

ci: improve release workflows#5949

Merged
jackye1995 merged 3 commits intolance-format:mainfrom
jackye1995:release-v2
Feb 13, 2026
Merged

ci: improve release workflows#5949
jackye1995 merged 3 commits intolance-format:mainfrom
jackye1995:release-v2

Conversation

@jackye1995
Copy link
Contributor

@jackye1995 jackye1995 commented Feb 13, 2026

  1. use relative release note for beta releases. Example fix: https://github.com/jackye1995/lance/releases/tag/v4.0.0-beta.5
  2. ensure RC voting period is correct. Example fix: [VOTE] Release Candidate v4.1.0-rc.3 jackye1995/lance#73
  3. implement minor release in release branch:

@jackye1995 jackye1995 marked this pull request as draft February 13, 2026 02:54
@github-actions github-actions bot added the ci Github Action or Test issues label Feb 13, 2026
@github-actions
Copy link
Contributor

Code Review

This PR makes two improvements to the release workflows:

  1. create_rc.sh: Correctly determines RELEASE_TYPE (major/minor/patch) based on version components instead of hardcoding patch
  2. publish_beta.sh: Uses relative release notes for beta releases (beta.2+ compares against previous beta instead of release-root)

Feedback

P1 - Potential bug in publish_beta.sh:

The BETA_NUM extraction uses sed, which assumes the version always contains beta. However, this parsing happens after the bump, where NEW_VERSION should always be a beta version due to the earlier validation at line 24. This appears safe, but consider adding a defensive check or comment clarifying that NEW_VERSION is guaranteed to be a beta version at this point.

Minor observation:

The PR description mentions point 3 with no content - appears to be an incomplete description. No action required for the code itself.

Overall the changes look reasonable and address the stated goals.

@jackye1995 jackye1995 marked this pull request as ready for review February 13, 2026 06:43
@jackye1995 jackye1995 merged commit e47c345 into lance-format:main Feb 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Github Action or Test issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants