feat(rust): introduce snapshot api#5886
Conversation
Code Review: feat(rust): introduce snapshot apiSummaryThis PR adds a new P0 Issues (Must Fix)1. Timestamp Semantics Issue - The
This inconsistency could cause Recommendation: Consider using the manifest's internal P1 Issues (Should Fix)1. Inefficient Repeated Listing in Filtering Methods Methods like // Each of these does a separate listing
let a = snapshots.within(1, 4).await?;
let b = snapshots.earlier_than(3, 2).await?;Recommendation: Consider caching the manifest list within the 2. The method .filter(|s| s.version_number() >= version) // includes the version itselfThis is inconsistent with Minor Suggestions (Non-blocking)
TestingGood test coverage overall. Tests appropriately use in-memory storage and cover edge cases. |
Implement #5885