fix(java): init allocator for new dataset when checkout branch/tag #5876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majin1102
reviewed
Feb 3, 2026
Contributor
majin1102
left a comment
majin1102
left a comment
There was a problem hiding this comment.
Thanks for working on this.
Left one comment.
| try (LockManager.ReadLock readLock = lockManager.acquireReadLock()) { | ||
| Preconditions.checkArgument(nativeDatasetHandle != 0, "Dataset is closed"); | ||
| return nativeCheckout(ref); | ||
| Dataset newDataset = nativeCheckout(ref); |
Contributor
There was a problem hiding this comment.
Maybe we could add some tests to verify operational after checking out branches?
Contributor
Author
There was a problem hiding this comment.
Add getSchema invoking on new dataset in test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the new dataset's allocator does not init. The operation on the new dataset will fail.
@majin1102 Could you please review it. Thank you .