-
Notifications
You must be signed in to change notification settings - Fork 540
feat: add rename table implementations to REST namespaces #5874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks for the work! pending CI green
|
I had to comment out the test assertions and added a TODO comment, because the REST adapter relies on the directory namespace implementation. I considered a couple of options, one was to implement rename in the directory namespace. The second was to create a new in-memory namespace implementation and use that with the REST adapter instead. Both of those options were fairly significant changes so I felt we could follow up with that in another PR. @jackye1995 do you have thoughts on that? |
This reverts commit ede47de.
This PR adds the Python and Java bindings for rename table using the REST namespace. This is already implemented in Rust.