fix: inconsistency inline constant handling for non‑fixed‑stride datatype#5851
Open
zhangyue19921010 wants to merge 3 commits intolance-format:mainfrom
Open
fix: inconsistency inline constant handling for non‑fixed‑stride datatype#5851zhangyue19921010 wants to merge 3 commits intolance-format:mainfrom
zhangyue19921010 wants to merge 3 commits intolance-format:mainfrom
Conversation
Contributor
Author
|
Hi @Xuanwo , would u mind to take a look at your convenient? Thanks! |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encoding side (rust/lance-arrow/src/scalar.rs)
try_inline_valuedecides whether a scalar value can be written inline. The old logic only checked that:However, it did not verify that the data type is fixed-stride or not. TAKE BOOLEAN AS EXAMPLE
Decoding side (decode_scalar_from_inline_value)
Decoding explicitly requires
data_type.byte_width_opt()to be present; otherwise it errors out:Inline constant is not supported for non-fixed-stride data type Boolean.This creates an inconsistency between the encoder and decoder.
Without this fix, new added unit test
test_constant_layout_out_of_line_boolean_v2_2and similar scenarios will report errors