Skip to content

Conversation

@hamersaw
Copy link
Contributor

The take_source function does not maintain fragment configuration for the overall scanner. This means that even if instructed to query a single fragment, it will query over the entire dataset.

Closes #5351

Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
@github-actions
Copy link
Contributor

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@hamersaw hamersaw changed the title bug: maintaining individual fragment operation when calling take_source fix: maintaining individual fragment operation when calling take_source Jan 29, 2026
@github-actions github-actions bot added the bug Something isn't working label Jan 29, 2026
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/dataset/scanner.rs 20.00% 4 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Fragment.scanner return wrong results when filter is _rowaddr=0

1 participant