fix(python): correct type hint for to_tensor_fn parameter #5577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes lance-format#3129 The type hint for in was declaring a single-argument callable, but the function is actually called with additional keyword arguments ( and ). Changes: - Update type hint to use to allow arbitrary args - Enhance docstring to document the expected function signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3129
Summary
The type hint for
to_tensor_fninLanceDataset.__init__incorrectly declared a single-argument callable, but the function is called with additional keyword arguments.Changes
Callable[[pa.RecordBatch], ...]toCallable[..., ...]to accurately reflect that the function accepts arbitrary argumentshf_converteranduse_blob_apikeyword argumentsTesting