feat(format): support recording list of index files and sizes#5545
Open
wjones127 wants to merge 3 commits intolance-format:mainfrom
Open
feat(format): support recording list of index files and sizes#5545wjones127 wants to merge 3 commits intolance-format:mainfrom
wjones127 wants to merge 3 commits intolance-format:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
westonpace
reviewed
Jan 22, 2026
Comment on lines
+292
to
+296
| message IndexFile { | ||
| // Path relative to the index directory (e.g., "index.idx", "auxiliary.idx") | ||
| string path = 1; | ||
| // Size of the file in bytes | ||
| uint64 size_bytes = 2; |
Member
There was a problem hiding this comment.
Should this be relative to the dataset URI and include a base_id? Otherwise how will this work if there are multiple bases?
Member
There was a problem hiding this comment.
Oh wait, I guess we are just saying that "a single index cannot be broken across multiple bases" which seems like a reasonable constraint?
Contributor
Author
|
Voted passed in #5757 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add file sizes to
IndexMetadataso we can optimize cold reads of indexes (avoid HEAD calls) and report index on-disk size without extra IO.For discussion, see: #5456
For implementation, see: #5497
This will require a vote before it can be merged.