-
Notifications
You must be signed in to change notification settings - Fork 502
perf: add fast path for simple projections #5532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Xuanwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, do we have a perf number?
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
114580a to
ec69ed2
Compare
Benchmark Results for PR #5532Commit: Summary
Flagged Benchmarks (|z-score| > 2.0)
All ResultsView all 221 benchmark results
Generated by bench-bot 🤖 |
|
I was using this PR to test out bench-bot but those results aren't the really interesting ones. The random take benchmark in the |
This should improve the performance of take operations.
Closes #5069