feat: add additional index APIs to support count rows split plan #5447
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
jackye1995
changed the title
majin1102
left a comment
majin1102
left a comment
There was a problem hiding this comment.
Thanks for working on this. Left some comments.
Please take a look
| * | ||
| * @return list of Index objects with complete metadata including index type and fragment coverage | ||
| */ | ||
| public List<org.lance.index.Index> getIndexes() { |
There was a problem hiding this comment.
Maybe we could use the short name and import it
| } | ||
| } | ||
|
|
||
| private native List<org.lance.index.Index> nativeGetIndexes(); |
| Ok(array_list) | ||
| } | ||
|
|
||
| fn create_java_index<'local>( |
There was a problem hiding this comment.
I guess this is duplicated with https://github.com/majin1102/lance/blob/772c6d87a5b1d9530b5f3772fba7c33cf5c55b3a/java/lance-jni/src/transaction.rs#L81-L170
Maybe we should move that code here and add this index_type
| * | ||
| * @return a new Index instance | ||
| */ | ||
| public static Index create( |
There was a problem hiding this comment.
I wonder this should be a "create". It doesn't look like not a create index but only generate an object.
I think we could just use the private constructor in JNI?
2 participants
Related to lance-format/lance-spark#140