Skip to content

Conversation

@jackye1995
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 73.91931% with 362 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.75%. Comparing base (85d44b6) to head (958ae2b).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-namespace-impls/src/rest.rs 56.13% 216 Missing and 2 partials ⚠️
rust/lance-namespace-impls/src/dir.rs 90.88% 49 Missing and 17 partials ⚠️
rust/lance-namespace/src/namespace.rs 0.00% 48 Missing ⚠️
rust/lance-namespace-impls/src/connect.rs 0.00% 20 Missing ⚠️
rust/lance-namespace/src/schema.rs 89.89% 0 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4978      +/-   ##
==========================================
- Coverage   81.81%   81.75%   -0.06%     
==========================================
  Files         335      340       +5     
  Lines      135486   136884    +1398     
  Branches   135486   136884    +1398     
==========================================
+ Hits       110847   111916    +1069     
- Misses      20952    21247     +295     
- Partials     3687     3721      +34     
Flag Coverage Δ
unittests 81.75% <73.91%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this PR after all CI pass.

@jackye1995 jackye1995 merged commit dcc3f51 into lance-format:main Oct 16, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants