Skip to content

feat(java): support config operation for Dataset#4039

Merged
jackye1995 merged 3 commits intolance-format:mainfrom
majin1102:java_config
Jun 30, 2025
Merged

feat(java): support config operation for Dataset#4039
jackye1995 merged 3 commits intolance-format:mainfrom
majin1102:java_config

Conversation

@majin1102
Copy link
Contributor

epic: #3950

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 86 lines in your changes missing coverage. Please review.

Project coverage is 78.63%. Comparing base (1afdf3f) to head (d3f8c2e).

Files with missing lines Patch % Lines
java/core/lance-jni/src/blocking_dataset.rs 0.00% 83 Missing ⚠️
rust/lance/src/dataset.rs 0.00% 2 Missing ⚠️
java/core/lance-jni/src/utils.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4039      +/-   ##
==========================================
- Coverage   78.68%   78.63%   -0.06%     
==========================================
  Files         285      285              
  Lines      113471   113544      +73     
  Branches   113471   113544      +73     
==========================================
- Hits        89289    89288       -1     
- Misses      20758    20834      +76     
+ Partials     3424     3422       -2     
Flag Coverage Δ
unittests 78.63% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@majin1102
Copy link
Contributor Author

majin1102 commented Jun 27, 2025

@jackye1995 @yanghua The code has been rebased and ready to review

Copy link
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@jackye1995 jackye1995 merged commit 9370f3b into lance-format:main Jun 30, 2025
8 checks passed
@majin1102 majin1102 deleted the java_config branch September 10, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants