Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic reset methods #3

Merged
merged 4 commits into from
Aug 23, 2021
Merged

Add semantic reset methods #3

merged 4 commits into from
Aug 23, 2021

Conversation

Phrlog
Copy link

@Phrlog Phrlog commented Dec 19, 2019

Usually you want to have separated methods for request/mapping reset.

Old cleanAllPreviousRequestsToWireMock method naming was a bit misleading, so I add resetMappingsAndRequestJournalInWireMock to replace it.

@Phrlog Phrlog requested a review from a team December 19, 2019 11:45
Copy link

@scaytrase scaytrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@scaytrase scaytrase merged commit 17f9ded into master Aug 23, 2021
@scaytrase scaytrase deleted the add-semantic-reset-methods branch August 23, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants