Small revisions for WHAM 2.1.0 release and figure placement #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongravelle
approved these changes
Mar 17, 2025
Member
simongravelle
left a comment
simongravelle
left a comment
There was a problem hiding this comment.
LGTM
I made some minor changes to homogenize the use of g/mol all over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@simongravelle Alan Grossfield has included most of my suggested changes, so WHAM version 2.1.0 can be used directly with the tutorial.
I've updated the text and BibTeX reference accordingly.
Also, I moved around some more figures so that they are better distributed across the pages and don't bunch up in places or lead to "holes".
My schedule doesn't look like there is going to be much more time on my hands in the coming weeks, and there are two more papers waiting for my contributions. So rather than delaying this even more, I suggest to submit and get it done with soon. It was great before we starting revising it and it is quite improved now. Better to get it out there and wait for bug reports and consider additions/revisions later.
I am planning to release LAMMPS version 29Aug2024 update 2 on Monday and the next LAMMPS feature release in early April and both with have LAMMPS-GUI 1.6.12 included which is required to have all features used in the tutorial.