Initial RFC for Doctype Replacement Helper #142
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think the doctype helper could do with a lot of simplification and the added file
DoctypeV3
is what I think the helper should look like:Removed functionality:
If something like this can be agreed in principal, I'll rename/replace the existing helper and factory to suit and write/update all the tests broken by the change.
I'll also create a pull for the 2.x series with all the deprecations.