Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.4 #17

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

weierophinney
Copy link
Member

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Description

This patch expands the PHP constraint to allow PHP 8.4.
No other additional changes are required to support the new version.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney weierophinney added this to the 2.12.0 milestone Nov 25, 2024
Makes it possible to identify deprecation errors and correct them.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney
Copy link
Member Author

Bumped the PHPUnit version to 10.5, as I was hitting deprecation errors I could not resolve in CI (not present when testing locally). This works correctly now across all versions.

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @weierophinney :)

@gsteel gsteel self-assigned this Nov 25, 2024
@gsteel gsteel merged commit 927d943 into laminas:2.12.x Nov 25, 2024
12 of 13 checks passed
@weierophinney weierophinney deleted the feature/php-8.4 branch November 25, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants