Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow dealerdirect/phpcodesniffer-composer-installer to run as composer plugin #10

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

localheinz
Copy link
Member

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

This pull request

  • allows dealerdirect/phpcodesniffer-composer-installer to run as composer plugin

…omposer plugin

Signed-off-by: Andreas Möller <am@localheinz.com>
@froschdesign
Copy link
Member

@localheinz
Do you also want to upgrade this component to version 8.3 of PHP, remove 8.0 and upgrade to version 10 of PHPUnit?

@localheinz
Copy link
Member Author

@froschdesign sure, why not?

I’m mostly looking for #11, but the question here is whether this package even accepts contributions. What do you think?

@froschdesign
Copy link
Member

@localheinz
This package is in security-only maintenance mode but we accept contributions to upgrade the PHP version.

@froschdesign froschdesign added this to the 2.10.0 milestone Oct 27, 2023
@froschdesign froschdesign added the Bug Something isn't working label Oct 27, 2023
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accept it at this point so that the work can continue.

@froschdesign froschdesign merged commit 8bed936 into laminas:2.10.x Oct 27, 2023
@localheinz localheinz deleted the fix/allow branch October 27, 2023 12:34
@localheinz
Copy link
Member Author

Thank you, @froschdesign!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants