Move laminas-validator to require dependencies and bump the version with all dependencies#126
Closed
marcelthole wants to merge 1 commit intolaminas:3.0.xfrom
Closed
Conversation
…ith all dependencies Signed-off-by: Marcel Thole <marcel@marcelthole.de>
Member
|
@marcelthole |
Author
|
@froschdesign i guess it should be possible. The only real usage is the Than we could document it in the Migration guide that the consumer must use something like this: 'MySessionContainer' => static fn (ContainerInterface $c): \Laminas\Session\Container => new \Laminas\Session\Container('MySessionContainerNamespace', $c->get(ManagerInterface::class));But i guess it make sense to split this in a second PR? Than i would create a Issue and PR for that one 👍 |
Author
|
Ahh i see there is already a duplicate in #103 |
Member
|
this PR was implemented in #103 |
This was referenced May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moved laminas-validator to the require section and bumped directly the version to
^3.0. This required to update some more dependencies and fix issues in the factories afterward.I tried to make this PR as small as possible and didn't added typehints for methods that doesn't require it yet.
Relates to #114