Skip to content

Move laminas-validator to require dependencies and bump the version with all dependencies#126

Closed
marcelthole wants to merge 1 commit intolaminas:3.0.xfrom
marcelthole:require-latest-laminas-validator
Closed

Move laminas-validator to require dependencies and bump the version with all dependencies#126
marcelthole wants to merge 1 commit intolaminas:3.0.xfrom
marcelthole:require-latest-laminas-validator

Conversation

@marcelthole
Copy link

Q A
BC Break yes

Description

Moved laminas-validator to the require section and bumped directly the version to ^3.0. This required to update some more dependencies and fix issues in the factories afterward.

I tried to make this PR as small as possible and didn't added typehints for methods that doesn't require it yet.

Relates to #114

…ith all dependencies

Signed-off-by: Marcel Thole <marcel@marcelthole.de>
@froschdesign
Copy link
Member

@marcelthole
You are adding support for laminas-servicemanager with version 4 here. Do you see a change to remove the dependency on the service manager?

@marcelthole
Copy link
Author

@froschdesign i guess it should be possible. The only real usage is the \Laminas\Session\Service\ContainerAbstractServiceFactory that could be removed.

Than we could document it in the Migration guide that the consumer must use something like this:

'MySessionContainer' => static fn (ContainerInterface $c): \Laminas\Session\Container => new \Laminas\Session\Container('MySessionContainerNamespace', $c->get(ManagerInterface::class));

But i guess it make sense to split this in a second PR? Than i would create a Issue and PR for that one 👍

@marcelthole
Copy link
Author

marcelthole commented Apr 30, 2025

Ahh i see there is already a duplicate in #103

@arhimede
Copy link
Member

arhimede commented May 2, 2025

this PR was implemented in #103

@arhimede arhimede closed this May 2, 2025
@marcelthole marcelthole deleted the require-latest-laminas-validator branch May 5, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants