Conversation
stanis-molnar
force-pushed
the
update-laminas-dependencies
branch
2 times, most recently
from
f4c1f0a to
3c0ed84
Compare
Signed-off-by: Daniel Molnar <stanis.molnar@gmail.com>
* AbstractFactoryInterface was moved to the factory subfolder * Using Psr\Container\ContainerInterface instead of Interop\Container\ContainerInterface * Adding return types Signed-off-by: Daniel Molnar <stanis.molnar@gmail.com>
Signed-off-by: Daniel Molnar <stanis.molnar@gmail.com>
…alidator Signed-off-by: Daniel Molnar <stanis.molnar@gmail.com>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
…onTrait::getListenersForEvent The Session ManagerInterface defines `getValidatorChain()` to return an `EventManagerInterface`, but `EventListenerIntrospectionTrait::getListenersForEvent()` expects an `EventManager` instance. For purposes of the tests, the returned value _is_ an EM instance, so the error is invalid. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Since the v2 `createService()` method cannot be removed before v4, we need to tell Psalm that (a) the method needs to exist, and (b) the second argument is required even if it's not used. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Since the v2 `createService()` method cannot be removed before v4, we need to tell Psalm that (a) the method needs to exist, and (b) the second argument is required even if it's not used. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Since the v2 `createService()` method cannot be removed before v4, we need to tell Psalm that (a) the method needs to exist, and (b) the second argument is required even if it's not used. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
- Made each of $config and $sessionManager props nullable, defaulting to null, as there is no constructor whereby they will be set by default. - Changed `isset()` calls on each property to check type of property instead. - Suppress PossiblyUnusedParam and PossiblyUnusedMethod warnings for v2 methods. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
- Specify `$id` arguments as non-empty-string values - Suppress RedundantCast, as the parent interface may not have the return types defined correctly in all versions of PHP Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
force-pushed
the
update-laminas-dependencies
branch
from
1ed3008 to
04c64db
Compare
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
|
@stanis-molnar — I've fixed the Psalm issues that were reported and pushed back to your branch. I missed the part where you indicated a new major would be needed. I'll check with the @laminas/technical-steering-committee to see how we clear the BC breaks, and verify everyone is okay with the new major. |
@weierophinney Thanks very much for taking care of that! Please let me know if any further actions on my side are needed. |
|
@weierophinney
Now with this PR we are confused if is the case or not to commit our PR's, since is a different approach :-) |
I wasn't aware you were working on one, @arhimede ; I reviewed this one initially as it looked like it might fit in the 2.23.0 milestone. When I wrote those commit messages, I'd forgotten that this was the v2 series; that should have read "before v3". I'm fine with waiting for your PR; marking deprecations first and then doing removal for next major makes sense. |
3 participants
This PR simply updates the laminas dependencies and adapts accordingly the use of the new major versions of laminas-servicemanager and laminas-validator.
I also removed the php annotations and added explicit return types to the modified classes.
This unfortunately breaks backwards compatibility and will require the release of a new major version of laminas-session.