-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce PHPStan (retry) #48
Conversation
@sasezaki please rebase against latest develop branch |
I give up rebase includes zendframework/zend-servicemanager#272, and would to Reopening of setup. |
Signed-off-by: sasezaki <sasezaki@gmail.com>
Signed-off-by: sasezaki <sasezaki@gmail.com>
Signed-off-by: sasezaki <sasezaki@gmail.com>
Signed-off-by: sasezaki <sasezaki@gmail.com>
Signed-off-by: sasezaki <sasezaki@gmail.com>
Signed-off-by: sasezaki <sasezaki@gmail.com>
Signed-off-by: sasezaki <sasezaki@gmail.com>
Signed-off-by: sasezaki <sasezaki@gmail.com>
according this vote, |
@sasezaki I think the fixes are valid: just need to swap out the CI tool |
@@ -10,6 +10,7 @@ | |||
|
|||
use Laminas\ServiceManager\Exception\ServiceNotFoundException; | |||
use Laminas\ServiceManager\Factory\AbstractFactoryInterface; | |||
use Laminas\Stdlib\DispatchableInterface; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mistake for
/**
* {@inheritDoc}
*
* @return DispatchableInterface
*/
public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
Not returned DispatchableInterface, just returned object - requestedName instance
Description