Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce PHPStan (retry) #48

Closed
wants to merge 8 commits into from
Closed

Conversation

sasezaki
Copy link
Contributor

@sasezaki sasezaki commented Jun 13, 2020

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

  • At this PR set up target level as 5, because level 6 is a lot of "no value type specified" occurred. and I feel requires remove current deprecations before level up to 6 or over.
  • travis setup is borrowed from phpstan fixes zendframework/zend-servicemanager#272

@samsonasik
Copy link
Member

@sasezaki please rebase against latest develop branch

@sasezaki
Copy link
Contributor Author

I give up rebase includes zendframework/zend-servicemanager#272, and would to Reopening of setup.
(Adding baseline & modify it, to be clear change reason )

sasezaki added 8 commits June 14, 2020 14:34
Signed-off-by: sasezaki <sasezaki@gmail.com>
Signed-off-by: sasezaki <sasezaki@gmail.com>
Signed-off-by: sasezaki <sasezaki@gmail.com>
Signed-off-by: sasezaki <sasezaki@gmail.com>
Signed-off-by: sasezaki <sasezaki@gmail.com>
Signed-off-by: sasezaki <sasezaki@gmail.com>
Signed-off-by: sasezaki <sasezaki@gmail.com>
Signed-off-by: sasezaki <sasezaki@gmail.com>
@sasezaki sasezaki changed the title [WIP] introduce PHPStan (retry) introduce PHPStan (retry) Jun 14, 2020
@sasezaki sasezaki marked this pull request as ready for review June 14, 2020 05:43
@sasezaki
Copy link
Contributor Author

sasezaki commented Aug 9, 2020

@sasezaki sasezaki closed this Aug 9, 2020
@Ocramius
Copy link
Member

Ocramius commented Aug 9, 2020

@sasezaki I think the fixes are valid: just need to swap out the CI tool

@@ -10,6 +10,7 @@

use Laminas\ServiceManager\Exception\ServiceNotFoundException;
use Laminas\ServiceManager\Factory\AbstractFactoryInterface;
use Laminas\Stdlib\DispatchableInterface;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mistake for

    /**
     * {@inheritDoc}
     *
     * @return DispatchableInterface
     */
    public function __invoke(ContainerInterface $container, $requestedName, array $options = null)

Not returned DispatchableInterface, just returned object - requestedName instance

@sasezaki sasezaki deleted the phpstan branch February 11, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants