PHP 8.4 support added #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cod43156
commented
Oct 15, 2024
cod43156
commented
| Q | A |
|---|---|
| Documentation | yes/no |
| Bugfix | yes/no |
| BC Break | yes/no |
| New Feature | yes/no |
| RFC | yes/no |
| QA | yes/no |
cod43156
force-pushed
the
php8.4_support
branch
2 times, most recently
from
067a2b1 to
d213fa2
Compare
Signed-off-by: Raj Mohan <cod43156@adobe.com>
cod43156
force-pushed
the
php8.4_support
branch
from
9bc7bfb to
2f2f51c
Compare
|
@gsteel Can you please review this and let us know if anything else is required from our side ? |
gsteel
requested changes
Nov 21, 2024
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
cod43156
force-pushed
the
php8.4_support
branch
from
54b05b6 to
456ce5a
Compare
gsteel
requested changes
Nov 25, 2024
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: cod43156 <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: cod43156 <cod43156@adobe.com>
|
@gsteel The review comments have been addressed. Kindly re-review. |
gsteel
requested changes
Dec 9, 2024
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
|
@gsteel The above changes reverted |
gsteel
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Looks OK to me, requesting review from @weierophinney because I'm not familiar with this codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.