PHP8.4 Support Added #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cod43156
commented
Oct 10, 2024
cod43156
commented
| Q | A |
|---|---|
| Documentation | yes/no |
| Bugfix | yes/no |
| BC Break | yes/no |
| New Feature | yes/no |
| RFC | yes/no |
| QA | yes/no |
|
@cod43156 Please rebase onto |
cod43156
force-pushed
the
php8.4_support
branch
from
6e5daaf to
704c9eb
Compare
Signed-off-by: Raj Mohan <cod43156@Rajs-MacBook-Pro.local> Signed-off-by: Raj Mohan <cod43156@adobe.com>
cod43156
force-pushed
the
php8.4_support
branch
from
704c9eb to
d529250
Compare
Signed-off-by: cod43156 <cod43156@adobe.com>
@gsteel Rebase onto 3.1.x is done, and all commits have been signed off as requested. |
gsteel
requested changes
Oct 14, 2024
.laminas-ci.json
Outdated
| @@ -3,6 +3,7 @@ | |||
| "igbinary" | |||
| ], | |||
| "ignore_php_platform_requirements": { | |||
| "8.3": true | |||
| "8.3": true, | |||
There was a problem hiding this comment.
Platform requirements no longer need to ignored on 8.3
There was a problem hiding this comment.
This change has been implemented
Signed-off-by: Raj Mohan <cod43156@adobe.com>
gsteel
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.